🎨 [Frontend] Wording: Don't say Failed, say Unsuccessful #7361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
giancarloromeo
approved these changes
Mar 14, 2025
GitHK
approved these changes
Mar 14, 2025
Contributor
GitHK
left a comment
GitHK
left a comment
There was a problem hiding this comment.
Thanks. This I spotted some more. Left some comments and suggestions
services/static-webserver/client/source/class/osparc/auth/ui/LoginView.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/organizations/MembersList.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/paymentMethods/PaymentMethods.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/file/FileDownloadLink.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/file/FileLabelWithActions.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/MergedLarge.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/ServiceLarge.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/StudyLarge.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/study/StudyOptions.js
Outdated
Show resolved
Hide resolved
…oginView.js Co-authored-by: Andrei Neagu <[email protected]>
…LabelWithActions.js Co-authored-by: Andrei Neagu <[email protected]>
…aymentMethods/PaymentMethods.js Co-authored-by: Andrei Neagu <[email protected]>
…DownloadLink.js Co-authored-by: Andrei Neagu <[email protected]>
…edLarge.js Co-authored-by: Andrei Neagu <[email protected]>
…dyOptions.js Co-authored-by: Andrei Neagu <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
…iceLarge.js Co-authored-by: Andrei Neagu <[email protected]>
…yLarge.js Co-authored-by: Andrei Neagu <[email protected]>
…rganizations/MembersList.js Co-authored-by: Andrei Neagu <[email protected]>
pcrespov
approved these changes
Mar 14, 2025
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In this PR, I get rid of the "Failed" word from the messages (created in the frontend) shown to the users, and these are replaced by "Unsuccessful".
Also, I took advantage to do some (noisy) refactoring in the way the FlashMessenger handles the errors, this will ease the work that needs to be done in the copy-OEC-to-clipboard issue.
Related issue/s
How to test
Dev-ops checklist